auth: use NATS.NKeys package for nkey signing#1101
Merged
Merged
Conversation
The Ed25519 reference implementation under NaCl/ and the partial public NKeys/NKeyPair API have lived in NATS.Client.Core since the fork from AlterNats. The NATS.NKeys package now ships the same functionality as a maintained, audited dependency, so the in-tree copy can go. UserCredentials signs through NATS.NKeys.KeyPair instead, producing byte-for-byte identical signatures. The legacy NKeyPair.Sign also wiped its expanded private key after the first call, so any external caller signing more than once would silently get bad signatures; in-tree usage was always one-shot so behavior is unchanged. This removes the public NATS.Client.Core.NKeys and NKeyPair types. External callers must switch to NATS.NKeys.KeyPair.
This was referenced Apr 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the in-tree Ed25519/NKey implementation with the NATS.NKeys package, dropping the vendored NaCl reference implementation and the partial public
NKeys/NKeyPairAPI. Signing now goes throughNATS.NKeys.KeyPairand produces byte-for-byte identical signatures.BREAKING Note this removes the public
NATS.Client.Core.NKeysandNKeyPairtypes: external callers must switch toNATS.NKeys.KeyPair.